Changeset 660f70f4c4c169214da8ac670fbecfb37ce3d2d5

Timestamp:

03/06/10 16:56:24 (5 months ago)

Author:

Joshua Brindle <method@manicmethod.com>

Committer:

Joshua Brindle <method@manicmethod.com> 1267916184 -0500

Parent:

[c8d100bb03e0fe0501037b914fe3638afd593ee4]

Message:

Author: Daniel J Walsh
Email: dwalsh@redhat.com
Subject: Fix memory leak on disabled selinux machines.
Date: Wed, 24 Feb 2010 14:15:31 -0500

I think this patch originally came from Eric Paris and was updated by
others but has not been adopted yet. Not sure why.

Always free buf on exit.

Signed-off-by: Joshua Brindle <method@manicmethod.com>

Files:

• libselinux/src/init.c (modified) (4 diffs)

libselinux/src/init.c

@@ -24 +24 @@
-{
-        char *buf=NULL, *p;
-
+=NULL
-        struct statfs sfbuf;
-        int rc;
@@ -58 +58 @@
-                }
-        }
+
+        if (!exists) 
+                goto out;
+
-        fclose(fp);
-
-        if (!exists)
-                return;
-
-        /* At this point, the usual spot doesn't have an selinuxfs so
@@ -67 +68 @@
-        fp = fopen("/proc/mounts", "r");
-        if (!fp)
-return
+goto out
-
-        __fsetlocking(fp, FSETLOCKING_BYCALLER);
@@ -91 +92 @@
-      out:
-        free(buf);
-
+
+
-        return;
-}